Finalize split #3388
Merged
Finalize split #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3388 +/- ##
=========================================
Coverage ? 64.27%
=========================================
Files ? 176
Lines ? 6538
Branches ? 4
=========================================
Hits ? 4202
Misses ? 2335
Partials ? 1
Continue to review full report at Codecov.
|
aaronabramov
approved these changes
Apr 27, 2017
Closed
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Finalize the split between configs. * Coverage mapping * Rename `config` to `globalConfig`
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On top of #3376, this now finalizes the split of "InitialOptions" into "ProjectConfig" and "GlobalConfig". The only overlap between the two is
rootDir, which should be alright. I have about five more PRs coming that clean up various things, but this one makes everything that is tested by Jest work. I'm sure I missed one or two things that aren't properly typed, but we have a fully week to stabilize this :)Test plan
jest