-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuation to #3771 for snake case file naming #3920
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3920 +/- ##
=======================================
Coverage 58.09% 58.09%
=======================================
Files 195 195
Lines 6751 6751
Branches 6 6
=======================================
Hits 3922 3922
Misses 2826 2826
Partials 3 3
Continue to review full report at Codecov.
|
@aaronabramov Any inputs for which eslint-plugin to use to enforce this naming convention? |
unicorn has it |
@SimenB It is running for every file including documentation(MD) files. I don't see any configuration to control this. |
Disable it in |
@SimenB Thanks..! Let me take a look. |
package.json
Outdated
@@ -114,5 +114,8 @@ | |||
"testMatch": [ | |||
"**/*.test.js" | |||
] | |||
}, | |||
"dependencies": { | |||
"eslint-plugin-unicorn": "^2.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev dep, not dep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB I thought I did it for dev dep..
@anilreddykatta did you figure it out? it passes locally. |
@aaronabramov They were failing locally. I tested on another machine it worked. I added |
@anilreddykatta sounds like a plan! |
@aaronabramov Loving it! |
* Resolved conflicts * Including eslint file for forcing file names * renaming files * renaming files
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Conitnuation to #3771. This is WIP. Adding eslint-plugin to enfore this rule. Addresses #3890
Test plan