-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include fullName in formattedAssertion #4273
Conversation
|
||
'use strict'; | ||
|
||
const formatTestResults = require('../formatTestResults'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be using underscores to match packages/jest-util/src/format_test_results.js
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source file's name is formatTestResults.js
while lint asks me to snake_case the test file. Not sure what's the right way to unify them..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can rename that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, what? The source file on latest master is format_test_results.js
, so I'm not sure if I understand that comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I didn't notice that after I rebase. If that's the case, how come the require
worked??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, because this was called _test
but we only look for .test
files, so this wasn't actually run. I'll fix it.
I'll figure out what's wrong with the tests and the require name. |
Thank you for following up on this and sending a PR. I apologize for closing the initial PR. I think I was pretty stressed out then and didn't have a lot of time reviewing this properly :) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Reinstate of #3378 with added tests.
Test plan