Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the maxWorkers has a value and raises an exception otherwise #4591

Merged
merged 3 commits into from
Oct 3, 2017
Merged

Check if the maxWorkers has a value and raises an exception otherwise #4591

merged 3 commits into from
Oct 3, 2017

Commits on Oct 3, 2017

  1. Check if the maxWorkers has a value and raises an exception otherwise 

    In this commit we are adding a new validation in the check method of the
jest-cli package, so we raise an exception if the user tries to run Jest
with undefined maxWorkers, e.g.

jest --maxWorkers

jest --maxWorkers 2

Some users were confusing -w as an alias to --watch, but in fact it is
an alias to --maxWorkers. This change will also make this distinction
clearer.

Fixes issue #4577
    @nicolasiensen
    nicolasiensen committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    f48c6be View commit details
    Browse the repository at this point in the history

  2. Add expected exception message in the check method tests

    @nicolasiensen
    nicolasiensen committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    07c0674 View commit details
    Browse the repository at this point in the history

  3. Improve error message for when maxWorkers is undefined

    @nicolasiensen
    nicolasiensen committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    2ff0f6b View commit details
    Browse the repository at this point in the history