Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for date in jest-get-type #4621

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Add support for date in jest-get-type #4621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/jest-get-type/src/__tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ describe('.getType()', () => {
test('regexp', () => expect(getType(/abc/)).toBe('regexp'));
test('map', () => expect(getType(new Map())).toBe('map'));
test('set', () => expect(getType(new Set())).toBe('set'));
test('date', () => expect(getType(new Date())).toBe('date'));
});
5 changes: 4 additions & 1 deletion packages/jest-get-type/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,15 @@ export type ValueType =
| 'regexp'
| 'map'
| 'set'
| 'date'
| 'string'
| 'symbol'
| 'undefined';

// get the type of a value with handling the edge cases like `typeof []`
// and `typeof null`
const getType = (value: any): ValueType => {
if (typeof value === 'undefined') {
if (value === undefined) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined is read only in ES5 and up, so no reason for this check (unless I'm missing something really obvious)

return 'undefined';
} else if (value === null) {
return 'null';
Expand All @@ -47,6 +48,8 @@ const getType = (value: any): ValueType => {
return 'map';
} else if (value.constructor === Set) {
return 'set';
} else if (value.constructor === Date) {
return 'date';
}
return 'object';
// $FlowFixMe https://github.com/facebook/flow/issues/1015
Expand Down