Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unofficial Node.js 4 support #5134

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Fix unofficial Node.js 4 support #5134

merged 1 commit into from
Dec 19, 2017

Conversation

ai
Copy link
Contributor

@ai ai commented Dec 19, 2017

Please remember to update CHANGELOG.md in the root of the project if you have not done so. -->

Do I need to update CHANGELOG.md for unofficial fixes?

Summary

I fixed Node.js 4 support to use Jest 22 in PostCSS, Autoprefixer, and Browserslist according to our plan in #5122

Test plan

I didn’t fix ... in tests since Node.js 4 support is unofficial

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #5134 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5134   +/-   ##
======================================
  Coverage    60.7%   60.7%           
======================================
  Files         201     201           
  Lines        6691    6691           
  Branches        4       4           
======================================
  Hits         4062    4062           
  Misses       2628    2628           
  Partials        1       1
Impacted Files Coverage Δ
packages/jest-config/src/normalize.js 91.95% <ø> (ø) ⬆️
packages/jest-editor-support/src/Runner.js 58.49% <0%> (ø) ⬆️
packages/jest-resolve/src/index.js 97.39% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74fbff...40dea3c. Read the comment docs.

@cpojer cpojer merged commit 884321d into jestjs:master Dec 19, 2017
@cpojer
Copy link
Member

cpojer commented Dec 19, 2017

Thanks. I published [email protected]. Good luck!

@ai
Copy link
Contributor Author

ai commented Dec 19, 2017

Thanks. It was really fast :).

@ai ai deleted the node4 branch December 19, 2017 14:05
@ai
Copy link
Contributor Author

ai commented Dec 19, 2017

@cpojer hm, strange. I fixed jest-config/src/normalize.js, but jest-config/build/normlize.js still contains ...: https://travis-ci.org/postcss/postcss/jobs/318631419

I checked jest-config/package.json, it has 22.0.2. Maybe this PR was not released?

@cpojer
Copy link
Member

cpojer commented Dec 19, 2017

I'm an idiot, I'll fix it in an hour.

@cpojer
Copy link
Member

cpojer commented Dec 19, 2017

Alright done, it's 22.0.3 -.-

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants