-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add jest-mongodb example #5571
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #5571 +/- ##
=======================================
Coverage 61.72% 61.72%
=======================================
Files 213 213
Lines 7169 7169
Branches 4 4
=======================================
Hits 4425 4425
Misses 2743 2743
Partials 1 1 Continue to review full report at Codecov.
|
docs/MongoDB.md
Outdated
``` | ||
|
||
Note: you may need to modify test script to run jest sequentially, like that: | ||
`jest --runInBand --forceExit`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forceExit
should not be necessary unless the db is not clean up properly - which it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup? We cannot advice that in a tutorial, that's just an escape hatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn auto correct, pardon that question mark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I added this at the very beginning, might be not needed anymore, let me see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, found the problem and fixed, no need for --forceExit
now
No more failing tests because of timeout, like it was with |
docs/MongoDB.md
Outdated
}; | ||
``` | ||
|
||
Then we need a custom Test Environment for puppeteer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say "for Mongo"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed the fix, looks great!
# Conflicts: # CHANGELOG.md
Thanks for improving Jest's documentation! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Inspired by #5093 I added an example how to setup jest with mongodb in-memory server to write tests
Test plan
Tests are running in CI using example: https://circleci.com/gh/vladgolubev/jest-mongodb