Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unbreak master #5672

Merged
merged 4 commits into from
Feb 26, 2018
Merged

Fix: unbreak master #5672

merged 4 commits into from
Feb 26, 2018

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented Feb 26, 2018

Summary

Fix a test from #5658 (cc @orta) and adjust circle config a bit

Test plan

@@ -1,15 +1,15 @@
aliases:
- &restore-cache
keys:
- dependencies-{{ .Branch }}-{{ checksum "package.json" }}
- v1-dependencies-{{ .Branch }}-{{ "yarn.lock" }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now using yarn.lock as a cache key, as it's more adequate in this case.

@cpojer
Copy link
Member

cpojer commented Feb 26, 2018

please run prettier.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b789dca). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5672   +/-   ##
=========================================
  Coverage          ?   63.16%           
=========================================
  Files             ?      216           
  Lines             ?     7913           
  Branches          ?        4           
=========================================
  Hits              ?     4998           
  Misses            ?     2914           
  Partials          ?        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b789dca...a49df4d. Read the comment docs.

@thymikee thymikee merged commit f6f0c9c into jestjs:master Feb 26, 2018
@thymikee thymikee deleted the fix/unbreak-master branch February 26, 2018 21:02
@orta
Copy link
Member

orta commented Feb 26, 2018

Thank @thymikee

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants