Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependency explicitly for babel-plugin-istanbul #5799

Merged
merged 2 commits into from
Mar 20, 2018
Merged

fix: update dependency explicitly for babel-plugin-istanbul #5799

merged 2 commits into from
Mar 20, 2018

Conversation

chrisjlee
Copy link
Contributor

@chrisjlee chrisjlee commented Mar 14, 2018

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@codecov-io
Copy link

codecov-io commented Mar 14, 2018

Codecov Report

Merging #5799 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5799   +/-   ##
=======================================
  Coverage   63.74%   63.74%           
=======================================
  Files         216      216           
  Lines        7941     7941           
  Branches        3        4    +1     
=======================================
  Hits         5062     5062           
  Misses       2878     2878           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76afc2...cd23686. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn as well to update the lockfile

@ChristopheBougere
Copy link

Having this error (#5082) since December, I would really appreciate the update :)

@SimenB SimenB merged commit e566a8f into jestjs:master Mar 20, 2018
@chrisjlee chrisjlee deleted the patch-1 branch March 21, 2018 04:16
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "some of undefined" that are breaking unit tests
5 participants