-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run prettier on output in build dirs #5858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a bunch of snapshots use line numbers though, which they can change. IIRC there is a method to strip them before snapshotting; that's should be good enough to fix broken tests.
We need to do it that way because line numbers will not match in That's not true, sorry! I'm mixing repositories in my headsrc
VS build
, so updating the snapshot is not good enough.
Codecov Report
@@ Coverage Diff @@
## master #5858 +/- ##
==========================================
- Coverage 63.88% 63.82% -0.07%
==========================================
Files 216 216
Lines 7970 8149 +179
Branches 4 3 -1
==========================================
+ Hits 5092 5201 +109
- Misses 2877 2947 +70
Partials 1 1
Continue to review full report at Codecov.
|
🎉 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See #3497
Test plan