Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier on output in build dirs #5858

Merged
merged 4 commits into from
Mar 22, 2018
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 22, 2018

Summary

See #3497

Test plan

Copy link
Contributor

@mjesun mjesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a bunch of snapshots use line numbers though, which they can change. IIRC there is a method to strip them before snapshotting; that's should be good enough to fix broken tests.

We need to do it that way because line numbers will not match in src VS build, so updating the snapshot is not good enough. That's not true, sorry! I'm mixing repositories in my head

@codecov-io
Copy link

Codecov Report

Merging #5858 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5858      +/-   ##
==========================================
- Coverage   63.88%   63.82%   -0.07%     
==========================================
  Files         216      216              
  Lines        7970     8149     +179     
  Branches        4        3       -1     
==========================================
+ Hits         5092     5201     +109     
- Misses       2877     2947      +70     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-editor-support/src/index.js 63.15% <0%> (-36.85%) ⬇️
packages/jest-cli/src/run_jest.js 50.79% <0%> (-19.21%) ⬇️
packages/jest-haste-map/src/worker.js 78.68% <0%> (-18.82%) ⬇️
packages/jest-resolve/src/is_builtin_module.js 83.33% <0%> (-16.67%) ⬇️
packages/jest-cli/src/jest_hooks.js 66.66% <0%> (-16.67%) ⬇️
packages/jest-config/src/deprecated.js 45.45% <0%> (-4.55%) ⬇️
packages/jest-docblock/src/index.js 80% <0%> (-3.93%) ⬇️
packages/jest-util/src/format_test_results.js 76% <0%> (-3.17%) ⬇️
packages/jest-validate/src/validate_cli_options.js 65.11% <0%> (-2.39%) ⬇️
.../jest-editor-support/src/parsers/babylon_parser.js 92.2% <0%> (-2.16%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a77ee3...2d717c4. Read the comment docs.

@mjesun
Copy link
Contributor

mjesun commented Mar 22, 2018

🎉

@mjesun mjesun merged commit 69c11a0 into jestjs:master Mar 22, 2018
@SimenB SimenB deleted the prettify-output branch March 22, 2018 17:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants