Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves babel-jest into jest-config rather than jest-runtime #5931

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Apr 5, 2018

Summary

I noticed that jest-runtime doesn't make any require to babel-jest, so it doesn't need to be there. Inversely, jest-config needs babel-jest to be able to work properly (because of normalize), so it needs to be declared as a dependency.

I guess it was put this way so that babel-core would be used for both jest-config and jest-runtime, but that's an optimization that should be left to the package manager.

Test plan

Existing tests should pass, no new test should be needed.

@arcanis
Copy link
Contributor Author

arcanis commented Apr 5, 2018

cc @mjesun @cpojer

@codecov-io
Copy link

Codecov Report

Merging #5931 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5931   +/-   ##
=======================================
  Coverage   64.39%   64.39%           
=======================================
  Files         217      217           
  Lines        8273     8273           
  Branches        3        3           
=======================================
  Hits         5327     5327           
  Misses       2945     2945           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb02fd...6998d12. Read the comment docs.

@cpojer cpojer merged commit 6979b8e into jestjs:master Apr 5, 2018
@cpojer
Copy link
Member

cpojer commented Apr 5, 2018

Works for me!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants