-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(treeProcessor): revert a small change from the #5585 refactoring #6006
Conversation
…oring fixes jestjs#5964 moves the `wrapChildren` into higher scope to restore undocumented execution order
Should we add a test for this? But not document it, as IMO this behavior is not something anyone should depend on |
Codecov Report
@@ Coverage Diff @@
## master #6006 +/- ##
==========================================
- Coverage 64.32% 64.32% -0.01%
==========================================
Files 217 217
Lines 8312 8313 +1
Branches 3 4 +1
==========================================
Hits 5347 5347
- Misses 2964 2965 +1
Partials 1 1
Continue to review full report at Codecov.
|
I don't believe I have enough context to write a good test for this. If somebody (@mjesun maybe?) with better knowledge of how Facebook depends on this behavior wants to write an integration test, go for it. |
You can use the one I put up on the issue as an integration test, asserting |
I'll merge it, we can add a test in a separate PR. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #5964 by partly restoring behavior from before #5585.
Moves the
wrapChildren
into higher scope to enforce undocumented execution order ofbeforeEach
added inside of tests.