Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prettier ignore pragmas to un-break the CI build #6587

Merged
merged 2 commits into from
Jul 1, 2018
Merged

Use prettier ignore pragmas to un-break the CI build #6587

merged 2 commits into from
Jul 1, 2018

Conversation

orta
Copy link
Member

@orta orta commented Jun 30, 2018

By letting the fetchSupporters run on node 6

Summary

Fixes CI 🎉

Test plan

This PR should be green?

@orta
Copy link
Member Author

orta commented Jun 30, 2018

I've got so used to saying "Merge on green" in the artsy/danger org that I actually wrote merge on green, then deleted it to write this

@connectdotz connectdotz mentioned this pull request Jul 1, 2018
Merged
@SimenB
Copy link
Member

SimenB commented Jul 1, 2018 •
edited
Loading

Can we fix this files array instead? https://github.com/facebook/jest/blob/227823086143807362e355b772cd110fc85ca590/.eslintrc.js#L59-L79

Just a 'website/fetchSuporters.js' in there should fix it. Then you can remove the prettier-ignores and just run eslint on the file. That will also guard against regressing on it

@orta
Copy link
Member Author

orta commented Jul 1, 2018

Perfect, yep

@SimenB SimenB merged commit b21a36e into master Jul 1, 2018
@SimenB SimenB deleted the fix_ci branch July 1, 2018 12:43
@rickhanlonii
Copy link
Member

Thanks for fixing my bug 🙈

@rickhanlonii rickhanlonii mentioned this pull request Jul 1, 2018
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orta @SimenB @rickhanlonii @facebook-github-bot