Handling pending calls inside async tests properly.

[matrushka]

Summary

Currently pending calls inside async tests causes the test to fail instead of getting skipped. Example:

it('should be pending', async () => {
  pending('skip');
});

With this PR pending calls inside async tests are handled properly as skipped tests.

Test plan

Was not able to find any tests for the current logic so was not able to figure out the test plan and did a manual testing. If someone can guide me about how to test this I'm willing to write the tests for it.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[codecov-io]

Codecov Report

Merging #6782 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #6782      +/-   ##
=========================================
- Coverage   66.61%   66.6%   -0.02%     
=========================================
  Files         253     253              
  Lines       10626   10629       +3     
  Branches        4       4              
=========================================
  Hits         7079    7079              
- Misses       3546    3549       +3     
  Partials        1       1

Impacted Files	Coverage Δ
packages/jest-jasmine2/src/jasmine_async.js	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d972e5...f440020. Read the comment docs.

[thymikee]

We're moving towards dropping Jasmine, so not sure if we want this change. @aaronabramov wdyt?

[SimenB]

If we don't wanna do this we should document the fact that jasmine is in maintenance and we'll just fix breaking bugs

[SimenB]

Doesn't hurt to fix this, I guess.

[SimenB]

This is missing an integration test. See contributing.md for information on how to write one.

Also, please update the changelog

[matrushka]

@SimenB I've done the changes but I guess circus doesn't have a pending method which causes the new test to fail in circus. How should I proceed?

[SimenB]

You can use https://github.com/facebook/jest/blob/2d972e5470c0e3365a2763279982ebf303136c0a/scripts/ConditionalTest.js#L24-L30 🙂

[matrushka]

Which one will you prefer?

1. Skipping the whole jasmine_async e2e suite with skipSuiteOnJestCircus()
2. Wrapping the new test with aisJestCircusRun() conditional
3. Moving the new test out to a separate file which has skipSuiteOnJestCircus()

[SimenB]

describe('global pending', () => {
  skipSuiteOnJestCircus();

  it('tests async promise when it skips during the test', () => {
    const result = runWithJson('jasmine-async', ['pending_in_promise.test.js']);
    const json = result.json;
    expect(json.numPendingTests).toBe(1);
  });
});

Or something like that? Whatever's cleanest

[SimenB]

not needed

[matrushka]

@SimenB done with the test as well. Moved it out to avoid changing previous tests and now it passes all checks.

[SimenB]

Thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.