-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock inherited static properties and methods #6921
Mock inherited static properties and methods #6921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Mind adding a changelog?
5b11aa9
to
5858e12
Compare
5858e12
to
ca47196
Compare
I've seen some issues with this change in FB infra. I'll revert it until I find and fix the cause. |
This reverts commit c1d9c2e.
Reverts #6921 This causes some errors in Facebook tests, which means it could be breaking something. I'll investigate further and create a new PR.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Mocks don't implement inherited static properties. E.g.:
Bar.js:
Bar-test.js:
Test plan
See updated tests.