Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock inherited static properties and methods #6921

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

rubennorte
Copy link
Contributor

Summary

Mocks don't implement inherited static properties. E.g.:

Bar.js:

class Foo {
  static foo() {}
}

class Bar extends Foo {}

Bar-test.js:

jest.mock('./Bar');
const Bar = require('./Bar');
Bar.foo; // undefined

Test plan

See updated tests.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Mind adding a changelog?

@rubennorte rubennorte force-pushed the mock-inherited-static-methods branch from 5b11aa9 to 5858e12 Compare August 30, 2018 11:36
@rubennorte rubennorte force-pushed the mock-inherited-static-methods branch from 5858e12 to ca47196 Compare August 30, 2018 11:36
@rubennorte rubennorte changed the title Mock inherited static methods Mock inherited static properties and methods Aug 30, 2018
@rubennorte rubennorte merged commit c1d9c2e into jestjs:master Aug 30, 2018
@rubennorte rubennorte deleted the mock-inherited-static-methods branch August 30, 2018 12:29
@rubennorte
Copy link
Contributor Author

I've seen some issues with this change in FB infra. I'll revert it until I find and fix the cause.

rubennorte added a commit that referenced this pull request Aug 30, 2018
SimenB pushed a commit that referenced this pull request Aug 30, 2018
Reverts #6921

This causes some errors in Facebook tests, which means it could be breaking something. I'll investigate further and create a new PR.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants