Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MongoDB.md #7305

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Update MongoDB.md #7305

merged 2 commits into from
Nov 2, 2018

Conversation

zakuni
Copy link
Contributor

@zakuni zakuni commented Oct 31, 2018

fix incorrect variable name for MongoMemoryServer object(both mongoServer and mongod were used) in the document.

Should I update CHANGELOG for fixing document? plz tell me if necessary.

Summary

It seems two different variable names(mongod and mongoServer) are used for MongoMemoryServer, and since then check below(line33-36) won't work.

if (!mongod.isRunning) {
  await mongod.start();
}

I chose to use mongod to adjust example(https://github.com/vladgolubev/jest-mongodb/blob/master/setup.js), even though mongoServer seems clearer.

Closes #7320

Test plan

no test due to fixing document.

fix incorrect variable name for mongod(both `mongoServer` and `mongod` were used)
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Oct 31, 2018

Thanks for the PR! Could you update the versioned docs as well?
image

@zakuni
Copy link
Contributor Author

zakuni commented Nov 1, 2018

@SimenB Thanks, I've done it.

@SimenB SimenB merged commit dd6f79b into jestjs:master Nov 2, 2018
@zakuni zakuni deleted the patch-1 branch November 4, 2018 13:14
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants