-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate jest-serializer to TypeScript #7841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Changelog? |
Good call! |
@@ -18,7 +18,9 @@ import serializer from '..'; | |||
|
|||
const v8s = [ | |||
{ | |||
// @ts-ignore - Node 8+ only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of disabling all those node 8 checks, you should mybe patch the node types.
declare namespace NodeJS {
interface v8 {
// ...
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added global.d.ts
, hope it's ok? I'm new to TS :P
37fabc8
to
6a2b5ca
Compare
6a2b5ca
to
1051cd7
Compare
Codecov Report
@@ Coverage Diff @@
## master #7841 +/- ##
==========================================
- Coverage 64.8% 64.63% -0.18%
==========================================
Files 230 229 -1
Lines 8657 8615 -42
Branches 5 5
==========================================
- Hits 5610 5568 -42
Misses 3045 3045
Partials 2 2 Continue to review full report at Codecov.
|
Co-Authored-By: thymikee <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Jumping on a TS train 🚂
Test plan
Green CI