-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: handle non-iterable arrays in test environment #7993
Conversation
Doesn't even work :( Seems I gave up last time: #4630. And the test is purposefully ignored |
Totally. We've had other issues related to this and running the runner code in a different environment and then just share its globals with the test environment would probably solve them all. |
@aaronabramov tried that in #3880, not sure why he aborted the attempt? Some side channel talk with @cpojer perhaps? I think @mjesun attempted it at some point as well. I'll write it down for the summit in a few weeks, maybe we can figure out a way forward then |
The information I had was that |
|
This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #3879. I absolutely hate this solution. Maybe we should figure out a plan which allows us to run the test environment outside of the user sandbox? Would allow us to ditch the babel plugin, which is turning into a monster
Test plan
The test that was never run will now run, and hopefully pass