-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate @jest/reporters to TypeScript #7994
Conversation
I dont think the tests are part of this migration. Regarding this, you could probably raise a pr for this if it isn't too difficult. I did the same thing with DefinitelyTyped/DefinitelyTyped#33351
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome start!
Some PRs to definitelytyped fixing their types would be awesome 🙂
Sure thing! I will make the PRs soon. I'm also updating all the underscore properties. |
Feel free to add some definition files to your PR as you work - both to avoid waiting for definitelytyped to merge and so you can verify the changes does the job 🙂 |
e2e/snapshot-escape/__tests__/__snapshots__/snapshot.test.js.snap
Outdated
Show resolved
Hide resolved
Ok, that was quite challenging 😅 I have only one test failing though, so i'm almost there. @SimenB I'll continue as soon as i'm done working For now i've done the typings for |
Awesome! Happy to land this in Jest including typings at first, then go back and remove them once definitelytyped is updated |
I've finally resolved all the failing tests and wrong typings ✨ Now it should be ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! left some nits and questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thank you so much! Looking forward to seeing those PRs to DefinitelyTyped be merged so we can get rid of the inline typings here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Built diff:
Related PRs
@types/node-notifier
: [@types/node-notifier] Update typings DefinitelyTyped/DefinitelyTyped#33419@types/istanbul-lib-coverage
: [@types/istanbul-lib-coverage] Update typings DefinitelyTyped/DefinitelyTyped#33646Test plan
Green CI