-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create new @jest/console
package
#8030
Conversation
8256295
to
e17c919
Compare
Codecov Report
@@ Coverage Diff @@
## master #8030 +/- ##
=========================================
- Coverage 63.31% 63.3% -0.02%
=========================================
Files 263 263
Lines 10266 10268 +2
Branches 2098 2100 +2
=========================================
Hits 6500 6500
- Misses 3273 3275 +2
Partials 493 493
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense 👍
config: Config.ProjectConfig, | ||
) { | ||
// @ts-ignore: `_log` is `private` - we should figure out some proper API here | ||
testConsole._log = function fakeConsolePush( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like a nice followup to have a setter for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, some sort of "disable logging" would be nice. We inject the instance into the sandbox though, so probably hide it behind a Symbol
or something
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Keep cutting away at
jest-util
. First commit is from #8029, ignore it.Test plan
Green CI