Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method of obtaining git root (#3214) #8052

Merged
merged 9 commits into from
Mar 19, 2019
Merged

Change method of obtaining git root (#3214) #8052

merged 9 commits into from
Mar 19, 2019

Conversation

bwiercinski
Copy link
Contributor

Summary

Fixes #3214

On various environments like cygwin path returned by --show-toplevel is cygwin path, not windows path. Instead of that --show-cdup can be used and merged with root of npm project giving root of git repo

Test plan

I hope CICD test verify that this solution is still working on linux :)

On various environments like cygwin path returned by --show-toplevel is cygwin path, not windows path.
Instead of that --show-cdup can be used and merged with root of npm project giving root of git repo
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bwiercinski
Copy link
Contributor Author

...but sadly i figured out, that my fix is double-edged sword. Now root of the git project is correct, but args are still wrong. on line 67
https://github.com/facebook/jest/blob/3666f323/packages/jest-changed-files/src/git.ts#L67

includePaths are Windows paths, but have to be cygwin path OR relative path e.g. ./my-ui.

I'm going to work on it during this week

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

For execa it does not matter if path is ended with folder separator
Instead of absolute path, use path relative to git root.
Thanks to that it works on various windows enviroments etc. Cygwin which
requires cygwin path if absolute
for case path.relative(dir, dir) returning ''
@bwiercinski
Copy link
Contributor Author

done

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: spawn git ENOENT on Windows 8
4 participants