Use react-is instead of manual element type checks in pretty-format #8058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackness
changed the title
mackness
changed the title
|
Super grateful for the PR @mackness, but @Prabhakar-17 has been working on this for some time, so I'd like to see his PR merged instead. |
|
@SimenB Totally understand, I'll look for another unclaimed issue :) |
|
Awesome, thanks for understanding! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of manually checking the element's
$$typeofsymbol in the pretty-format package, the react-is package can be used to accomplish the same element checks in a nicer way. Resolves #7895Test plan
Since there is no functionality change existing tests should suffice.