-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made toHaveBeenCalled example clearer #8179
made toHaveBeenCalled example clearer #8179
Conversation
added a function definition to give greater context to weird octopus reference ¯\_(ツ)_/¯
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SimenB - I've updated the spelling and added the updated code example to the other expectAPI docs also. |
Codecov Report
@@ Coverage Diff @@
## master #8179 +/- ##
=======================================
Coverage 62.33% 62.33%
=======================================
Files 265 265
Lines 10465 10465
Branches 2543 2542 -1
=======================================
Hits 6523 6523
Misses 3359 3359
Partials 583 583 Continue to review full report at Codecov.
|
Awesome, thanks! |
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I added a function definition to give greater context to weird octopus reference ¯_(ツ)_/¯
As a junior developer that is new to Jest, I found this example really confusing. To make it clearer (the octopus reference really threw me off), I added a simple function to add context.