Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made toHaveBeenCalled example clearer #8179

Conversation

rachelfranklin1
Copy link
Contributor

@rachelfranklin1 rachelfranklin1 commented Mar 20, 2019

I added a function definition to give greater context to weird octopus reference ¯_(ツ)_/¯

As a junior developer that is new to Jest, I found this example really confusing. To make it clearer (the octopus reference really threw me off), I added a simple function to add context.

added a function definition to give greater context to weird octopus reference ¯\_(ツ)_/¯
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Good call on adding the actual function there

We have multiple versions of these docs, could you update the other ones as well?

image

website/versioned_docs/version-23.x/ExpectAPI.md Outdated Show resolved Hide resolved
@rachelfranklin1
Copy link
Contributor Author

Thanks @SimenB - I've updated the spelling and added the updated code example to the other expectAPI docs also.

@codecov-io
Copy link

Codecov Report

Merging #8179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8179   +/-   ##
=======================================
  Coverage   62.33%   62.33%           
=======================================
  Files         265      265           
  Lines       10465    10465           
  Branches     2543     2542    -1     
=======================================
  Hits         6523     6523           
  Misses       3359     3359           
  Partials      583      583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b680db...dc4aaa4. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Mar 21, 2019

Awesome, thanks!

@SimenB SimenB merged commit 4a49aeb into jestjs:master Mar 21, 2019
@rachelfranklin1 rachelfranklin1 deleted the docs/made-toHaveBeenCalled-example-clearer branch March 21, 2019 14:39
@joglr

This comment has been minimized.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants