-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emphasize 'mock' variable name exception in docs #8182
Conversation
The docs don't explicitly say that in the `mockImplementation` example `const mockPlaySoundFile = jest.fn();` is relying on some behind-the-scenes magic. Not sure why but the explanation didn't click for me and it seems like I'm not the only one. This is an attempt to highlight this point
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #8182 +/- ##
=======================================
Coverage 62.32% 62.32%
=======================================
Files 265 265
Lines 10469 10469
Branches 2545 2544 -1
=======================================
Hits 6525 6525
Misses 3361 3361
Partials 583 583 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Mind adding a changleog and update this part in versioned_docs
as well? :)
Thanks @jeffsee55! Could you sign the CLA so we can merge this? 🙂 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks for the formatting fix @SimenB. I'd put the wrong email down on my previous CLA, should be ok now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The docs don't explicitly say that in the
mockImplementation
exampleconst mockPlaySoundFile = jest.fn();
is relying on some behind-the-scenes magic. Not sure why but the explanation didn't click for me and it seems like I'm not the only one. This is an attempt to highlight this pointFor reference: #2567 (comment)