-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use testPathPattern as a filter on top of findRelatedTests #8311
Commits on Apr 11, 2019
-
use testPathPattern as a filter on top of findRelatedTests
Mack Solomon committedApr 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 92837e0 - Browse repository at this point
Copy the full SHA 92837e0View commit details -
null check testPathPattern and eventually get around to fixing failin…
…g unit tests
Mack Solomon committedApr 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 808564a - Browse repository at this point
Copy the full SHA 808564aView commit details
Commits on Apr 12, 2019
-
use _filterTestPathsWithStats to to filter by with testPathPattern
Mack Solomon committedApr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for f7eafee - Browse repository at this point
Copy the full SHA f7eafeeView commit details -
Mack Solomon committed
Apr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for 5eddcbd - Browse repository at this point
Copy the full SHA 5eddcbdView commit details -
update _filterTestPathsWithStats condition
We only want to _filterTestPathsWithStats if testPathPattern was explicitly passed as an argument. The issue is that it's not possible to simply null check globalConfig.testPathPattern to determine if it was explicity passed becase that field gets populated with values passed to findRelatedTests also. This approach compares the values in globalConfig.testPathPattern to the values in globalConfig.nonFlagArgs and if it is a 1 to 1 match it is assumed that testPathPattern was not explicity passed as an argument.
Mack Solomon committedApr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for d83b4c6 - Browse repository at this point
Copy the full SHA d83b4c6View commit details
Commits on Apr 17, 2019
-
convert findRelatedTests parameter from a boolean to a string array
Mack Solomon committedApr 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 7ee3e54 - Browse repository at this point
Copy the full SHA 7ee3e54View commit details -
Mack Solomon committed
Apr 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 9d7aed1 - Browse repository at this point
Copy the full SHA 9d7aed1View commit details
Commits on Apr 24, 2019
-
fix instances of findRelatedTests
findRelatedTests used to be a boolean field. It has been updated to be Array<string>. We will check the length of the array to determine if findRelatedTests is falsy or truthy since 0 will evaluate to false and aything greater than 0 will evaluate to true.
1Configuration menu - View commit details
-
Copy full SHA for 813fab3 - Browse repository at this point
Copy the full SHA 813fab3View commit details
Commits on May 4, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b9ad8bc - Browse repository at this point
Copy the full SHA b9ad8bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2613dd0 - Browse repository at this point
Copy the full SHA 2613dd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17b4310 - Browse repository at this point
Copy the full SHA 17b4310View commit details
Commits on Jun 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f95a0d4 - Browse repository at this point
Copy the full SHA f95a0d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfa2569 - Browse repository at this point
Copy the full SHA bfa2569View commit details -
Configuration menu - View commit details
-
Copy full SHA for a85dd4b - Browse repository at this point
Copy the full SHA a85dd4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e99139 - Browse repository at this point
Copy the full SHA 4e99139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4169622 - Browse repository at this point
Copy the full SHA 4169622View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c001f7 - Browse repository at this point
Copy the full SHA 9c001f7View commit details
Commits on Jun 3, 2019
-
add a simple --testPathPattern assertion
simple test that asserts --testPathPattern will filter tests matched by --findRelatedTests
Configuration menu - View commit details
-
Copy full SHA for 144e6f0 - Browse repository at this point
Copy the full SHA 144e6f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e73ecd7 - Browse repository at this point
Copy the full SHA e73ecd7View commit details -
disable no-unresolved rule for fsevents
for some reason this lint command works locally but fails in CI eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md --format junit -o reports/junit/js-lint-results.xml
Configuration menu - View commit details
-
Copy full SHA for c33284d - Browse repository at this point
Copy the full SHA c33284dView commit details
Commits on Jun 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a938c25 - Browse repository at this point
Copy the full SHA a938c25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dc3269 - Browse repository at this point
Copy the full SHA 7dc3269View commit details