Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expect] optimize compare nodes #8368

Merged
merged 3 commits into from
Apr 27, 2019
Merged

[expect] optimize compare nodes #8368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
043092c
[expect] optimize compare nodes :art:
Connormiha Apr 23, 2019
9533e4c
Remove needless varible
Connormiha Apr 24, 2019
f0f6fae
Update CHANGELOG.md
pedrottimark Apr 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
- `[docs]` Mention Jest MongoDB Preset ([#8318](https://github.com/facebook/jest/pull/8318))
- `[@jest/reporters]` Migrate away from `istanbul-api` ([#8294](https://github.com/facebook/jest/pull/8294))
- `[*]` Delete obsolete emails tag from header comment in test files ([#8377](https://github.com/facebook/jest/pull/8377))
- `[expect]` optimize compare nodes ([#8368](https://github.com/facebook/jest/pull/8368))

### Performance

Expand Down
4 changes: 1 addition & 3 deletions packages/expect/src/jasmineUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,8 @@ function eq(
return false;
}

var aIsDomNode = isDomNode(a);
var bIsDomNode = isDomNode(b);
// Use DOM3 method isEqualNode (IE>=9)
if (aIsDomNode && typeof a.isEqualNode === 'function' && bIsDomNode) {
if (isDomNode(a) && isDomNode(b)) {
return a.isEqualNode(b);
}

Expand Down