fix: set MODULE_NOT_FOUND code when module is not resolved from paths

CHANGELOG.md

@@ -8,6 +8,7 @@
 
 - `[babel-plugin-jest-hoist]` Expand list of whitelisted globals in global mocks ([#8429](https://github.com/facebook/jest/pull/8429)
 - `[jest-core]` Make watch plugin initialization errors look nice ([#8422](https://github.com/facebook/jest/pull/8422))
+- `[jest-resolve]`: Set MODULE_NOT_FOUND as error code when module is not resolved from paths ([#8487](https://github.com/facebook/jest/pull/8487))
 
 ### Chore & Maintenance
 

e2e/__tests__/__snapshots__/moduleNameMapper.test.ts.snap

@@ -30,6 +30,6 @@ FAIL __tests__/index.js
       12 | module.exports = () => 'test';
       13 | 
 
-      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/index.js:472:17)
+      at createNoMappedModuleFoundError (../../packages/jest-resolve/build/index.js:479:17)
       at Object.require (index.js:10:1)
 `;

e2e/__tests__/__snapshots__/resolveNoFileExtensions.test.ts.snap

@@ -33,6 +33,6 @@ FAIL __tests__/test.js
         |                  ^
       4 | 
 
-      at Resolver.resolveModule (../../packages/jest-resolve/build/index.js:230:17)
+      at Resolver.resolveModule (../../packages/jest-resolve/build/index.js:238:17)
       at Object.require (index.js:3:18)
 `;

e2e/resolve-with-paths/__tests__/resolveWithPaths.test.js

@@ -35,3 +35,9 @@ test('throws an error if the module cannot be found from given paths', () => {
     "Cannot resolve module './mod.js' from paths ['..'] from "
   );
 });
+
+test('throws module not found error if the module cannot be found from given paths', () => {
+  expect(() => require.resolve('./mod.js', {paths: ['..']})).toThrow(
+    expect.objectContaining({code: 'MODULE_NOT_FOUND'})
+  );
+});

e2e/resolve/__tests__/resolve.test.js

@@ -98,3 +98,12 @@ test('should require resolve haste mocks correctly', () => {
 
   expect(require('Test6').key).toBe('mock');
 });
+
+test('should throw module not found error if the module cannot be found', () => {
+  expect(() => require('Test7')).toThrow(
+    expect.objectContaining({
+      code: 'MODULE_NOT_FOUND',
+      message: "Cannot find module 'Test7' from 'resolve.test.js'",
+    })
+  );
+});

packages/jest-resolve/src/ModuleNotFoundError.ts

@@ -0,0 +1,10 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+export default class ModuleNotFoundError extends Error {
+  code = 'MODULE_NOT_FOUND';
+}

packages/jest-resolve/src/defaultResolver.ts

@@ -12,6 +12,7 @@ import pnpResolver from 'jest-pnp-resolver';
 import {Config} from '@jest/types';
 import isBuiltinModule from './isBuiltinModule';
 import nodeModulesPaths from './nodeModulesPaths';
+import ModuleNotFoundError from './ModuleNotFoundError';
 
 type ResolverOptions = {
   basedir: Config.Path;
@@ -80,10 +81,9 @@ function resolveSync(
     return target;
   }
 
-  const err: Error & {code?: string} = new Error(
+  const err = new ModuleNotFoundError(
     "Cannot find module '" + target + "' from '" + basedir + "'",
   );
-  err.code = 'MODULE_NOT_FOUND';
   throw err;
 
   /*

packages/jest-resolve/src/index.ts

@@ -14,6 +14,7 @@ import nodeModulesPaths from './nodeModulesPaths';
 import isBuiltinModule from './isBuiltinModule';
 import defaultResolver from './defaultResolver';
 import {ResolverConfig} from './types';
+import ModuleNotFoundError from './ModuleNotFoundError';
 
 type FindNodeModuleConfig = {
   basedir: Config.Path;
@@ -102,6 +103,10 @@ class Resolver {
     return null;
   }
 
+  static createModuleNotFoundError(message?: string) {
+    return new ModuleNotFoundError(message);
+  }
+
   resolveModuleFromDirIfExists(
     dirname: Config.Path,
     moduleName: string,
@@ -205,10 +210,10 @@ class Resolver {
     // produces an error based on the dirname but we have the actual current
     // module name available.
     const relativePath = path.relative(dirname, from);
-    const err: Error & {code?: string} = new Error(
+
+    const err = new ModuleNotFoundError(
       `Cannot find module '${moduleName}' from '${relativePath || '.'}'`,
     );
-    err.code = 'MODULE_NOT_FOUND';
     throw err;
   }
 

packages/jest-runtime/src/index.ts

@@ -647,11 +647,12 @@ class Runtime {
           return module;
         }
       }
-      throw new Error(
+      const err = Resolver.createModuleNotFoundError(
         `Cannot resolve module '${moduleName}' from paths ['${paths.join(
           "', '",
         )}'] from ${from}`,
       );
+      throw err;
     }
     try {
       return this._resolveModule(from, moduleName);