Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CLI argument to filter tests by projects #8612
feat: CLI argument to filter tests by projects #8612
Changes from all commits
a3a0627
206c4f4
57d17db
92b68b7
54362dc
9c5513e
af1c221
b73f7e4
e8c7874
1cd4d1a
d318023
1c35afb
9916880
100ccdd
36e7294
d5a681c
8102c94
5550bc8
52eaa67
67a66f8
c0262e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually go with
console.warn
for warnings, but I don't think it matters this much hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.warn
will always write the string tostdout
, whereas with outputStream we will write to eitherstdout
orstderr
depending on what is appropriate.Here, if I replace
outputStream.write
byconsole.warn
the tests will fail as they rely on the JSON output, and the JSON output can only be valid if all messages are written tostderr
instead ofstdout
.