Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump dated deps #8693

Merged
merged 5 commits into from
Jul 15, 2019
Merged

chore: bump dated deps #8693

merged 5 commits into from
Jul 15, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 15, 2019 •
edited
Loading

Summary

#8692 with reduced scope - just the package.json changes without a full refresh of the lockfile. If this passes I'll rebase that and dig some more.

EDIT: ended up also bumping the eslint packages (within semver range) as they also necessitated some code changes

Test plan

Green CI

@SimenB SimenB mentioned this pull request Jul 15, 2019
Merged
@SimenB
Copy link
Member Author

SimenB commented Jul 15, 2019

Hmm, we've got one failure in e2e/__tests__/onlyChanged.test.ts, will look into it. Hopefully all else passes now

SimenB
SimenB commented Jul 15, 2019
View reviewed changes
packages/expect/src/__tests__/spyMatchers.test.js
@@ -870,197 +870,203 @@ const jestExpect = require('../');

const basicReturnedWith = ['toHaveReturnedWith', 'toReturnWith'];
if (basicReturnedWith.indexOf(returnedWith) >= 0) {
test(`works with more calls than the limit`, () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore whitespace here (jest eslint complained about duplicate test names (now discovered due to jest-community/eslint-plugin-jest#239))

@SimenB
Copy link
Member Author

SimenB commented Jul 15, 2019

Downgrading yargs fixes it. I guess it's this: https://github.com/yargs/yargs-parser/blob/master/CHANGELOG.md#1200-2019-01-29

a flag with no right-hand value no longer populates defaulted options with undefined.

@SimenB SimenB merged commit a36f82d into jestjs:master Jul 15, 2019
@SimenB SimenB deleted the bump-deps branch July 15, 2019 13:33
@SimenB
Copy link
Member Author

SimenB commented Jul 15, 2019 •
edited
Loading

Will follow up with a PR for yargs (tomorrow). I think we just need to supply a type to all flags, might be wrong though. The failing test does jest -all (which I didn't even know existed), but not all tests are run

@SimenB SimenB mentioned this pull request Jul 16, 2019
Merged
@SimenB SimenB mentioned this pull request Nov 9, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Jul 17, 2020
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimenB @facebook-github-bot