Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absolute path moduleNameMapper + jest.mock issue #8727

Merged
merged 1 commit into from
May 4, 2020

Conversation

chauchakching
Copy link
Contributor

@chauchakching chauchakching commented Jul 20, 2019

Summary

In this special case, the moduleNameMapper got applied to the import path twice, resulting in an invalid module path.

still validating the changes, WIP

Fixes #8633

Test plan

Added the absolute path moduleNameMapper test case.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Nov 9, 2019

Any news here? It seems sane to me, and tests are passing. Rebasing on master should fix the CI failure on circus

@thymikee
Copy link
Collaborator

thymikee commented May 3, 2020

@chauchakching ping 🙂. Is it ready to be out of Draft now?

@chauchakching chauchakching marked this pull request as ready for review May 4, 2020 04:23
@chauchakching chauchakching force-pushed the master branch 2 times, most recently from 8bb7673 to 9bf438d Compare May 4, 2020 06:16
@chauchakching
Copy link
Contributor Author

Almost forgot I had this PR...
Rebasing

@SimenB
Copy link
Member

SimenB commented May 4, 2020

Thanks @chauchakching! It seems tests are failing on CI, would you be able to take a look?

@chauchakching
Copy link
Contributor Author

Thanks @chauchakching! It seems tests are failing on CI, would you be able to take a look?

of course

@chauchakching
Copy link
Contributor Author

Screenshot 2020-05-04 at 7 25 10 PM

2 hg tests failed on my mac though, even on master branch

@SimenB
Copy link
Member

SimenB commented May 4, 2020

Yeah, ignore the mercurial tests, they only work on very specific versions of mercurial

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Could you add an entry to the changelog as well?

@SimenB
Copy link
Member

SimenB commented May 4, 2020

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel absolute path import issue
4 participants