Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-diff: Rename some new options and change their default values #9077

Merged
merged 9 commits into from
Oct 26, 2019

Conversation

pedrottimark
Copy link
Contributor

Summary

  1. Split and rename trailingSpaceFormatter option as prerequisite to improve snapshot colors:

    • changeLineTrailingSpaceColor because aColor and bColor might have background color
    • commonLineTrailingSpaceColor because dim does not modify like other colors
  2. Rename firstOrLastEmptyLineReplacement as emptyFirstOrLastLinePlaceholder

  3. Change default values so dependents can turn them on instead of need to turn them off (not breaking, because the new options have not yet been published)

  4. Edit README.md table and examples of new options

  5. Provide explicit values for these options in jest-matcher-utils and jest-snapshot

  6. Export DiffOptionsColor type so jest-snapshot can declare getSnapshotColor and getReceivedColor with conditional expression of chalk.level to return improved colors

Test plan

In jest-diff package:

  • diff.test.ts add 1 test and update 2 tests for trailingSpaceFormatter
  • joinAlignedDiffs.test.ts add emptyFirstOrLastLinePlaceholder which affects 3 tests

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is easier to grok 👍

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants