-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix broken transform link on webpack page #9155
Conversation
@@ -0,0 +1,234 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this file as it should use the one in docs
.
However, can you verify the other versioned docs are linked correctly? https://jestjs.io/en/versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check other versioned docs (Past Versions) are linked correctly. (/configuration#transform-object-string-string
)
And, I checked that link is broken in Current(24.9) and Latest version.
Because Configuration page's transform fragment was changed since #7288
(/configuration#transform-object-string-pathtotransformer-pathtotransformer-object
)
In development, I added this file to fix broken link in Current version(24.9).
Did I miss something or misunderstand in development and your feedback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it seems you've done it entirely correct. Thank you!
Codecov Report
@@ Coverage Diff @@
## master #9155 +/- ##
==========================================
- Coverage 64.82% 64.77% -0.05%
==========================================
Files 277 277
Lines 11734 11722 -12
Branches 2882 2877 -5
==========================================
- Hits 7606 7593 -13
- Misses 3511 3512 +1
Partials 617 617
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
transform
link onUsing with webpack
(https://jestjs.io/docs/en/webpack) is broken. So, it does not lead to configuration's transform section (https://jestjs.io/docs/en/configuration#transform-object-string-pathtotransformer-pathtotransformer-object).Test plan