Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Warn about node-notifier caveat on windows systems. #9454

Merged
merged 1 commit into from
Jan 26, 2020
Merged

docs: Warn about node-notifier caveat on windows systems. #9454

merged 1 commit into from
Jan 26, 2020

Conversation

StringEpsilon
Copy link
Contributor

fixes #9452

Summary

Fixes the issue #9452 by informing the user of the unexpected behavior of node-notifier when using --notify CLI param or the notify config option.

Test plan

Green CI. Just a documentation change.

@facebook-github-bot
Copy link
Contributor

Hi StringEpsilon! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #9454 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9454      +/-   ##
==========================================
+ Coverage   64.96%   64.97%   +0.01%     
==========================================
  Files         283      283              
  Lines       12104    12104              
  Branches     2990     2990              
==========================================
+ Hits         7863     7865       +2     
+ Misses       3604     3603       -1     
+ Partials      637      636       -1
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.22% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8607684...827dbcd. Read the comment docs.

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows 10] --notify does not create a notification.
4 participants