Treat setupFilesAfterEnv like setupFiles when normalizing configs against presets

[staylor]

The value of setupFiles from a local Jest config is concatenated to the value of setupFiles from a preset when the local Jest config specifies preset and setupFiles. The same should be true for setupFilesAfterEnv. Without this change, if the local Jest config wants to take advantage of the setupFilesAfterEnv files from the preset, it has to redeclare them:

// jest-preset-foo
module.exports = {
  setupFilesAfterEnv: ['a'],
};

// local jest.config.js
module.exports = {
  preset: 'jest-preset-foo',
  setupFilesAfterEnv: ['b'],
};

Before:
Value of setupFilesAfterEnv = ['b']

After:
Value of setupFilesAfterEnv = ['a', 'b']

[codecov-io]

Codecov Report

Merging #9495 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9495      +/-   ##
==========================================
+ Coverage      65%   65.02%   +0.02%     
==========================================
  Files         283      283              
  Lines       12131    12133       +2     
  Branches     3002     3004       +2     
==========================================
+ Hits         7886     7890       +4     
+ Misses       3604     3603       -1     
+ Partials      641      640       -1

Impacted Files	Coverage Δ
packages/jest-config/src/normalize.ts	77.87% <100%> (+0.12%)	⬆️
packages/expect/src/utils.ts	96.22% <0%> (+1.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a7787...e3cef0a. Read the comment docs.

[SimenB]

Good catch, thanks! Mind updating the changelog as well?

[jeysal]

LGTM, just missing a changelog entry (of type fix) as Simen said. Thanks!

[staylor]

added entry to changelog, thanks!

[SimenB]

Thank you!

[danielbayley]

@staylor @SimenB @jeysal But what if I want the local setupFilesAfterEnv to override the preset? This broke my jest-preset-coffeescript package, as I was relying on this previous behaviour… How can I do that now?

[wrslatz]

Same issue as @danielbayley ... we're working in a nx monorepo. We rely on having different setupFilesAfterEnv in root jest.config.js and in each app / lib in our monorepo.

The root config with a specific setupFilesAfterEnv is so that IDEs that only respect a single jest.config.js in the root of the project can run the jest tests across the entire monorepo. The underlying configs for each app / lib are customized to those projects but extend from the root jest.config.js to use some common config. An example where IDE support is now broken is with https://github.com/jest-community/vscode-jest.

See nrwl/nx#2344 (comment) and nrwl/nx#2314 (comment) for further details

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.