-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix diff highlight of symbol-keyed object. #9499
Fix diff highlight of symbol-keyed object. #9499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙂
Codecov Report
@@ Coverage Diff @@
## master #9499 +/- ##
==========================================
+ Coverage 65.01% 65.03% +0.01%
==========================================
Files 283 283
Lines 12135 12148 +13
Branches 3003 3009 +6
==========================================
+ Hits 7890 7900 +10
- Misses 3604 3606 +2
- Partials 641 642 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very solid, thanks @WeiAnAn!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for clear code and your willingness to add tests to the expect
package.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #9432.
Use
Object.getOwnPropertySymbols
to traverse object's symbol key can fix this issue.Thanks @pedrottimark to point out this edge case.
Test plan
Add symbol-keyed object tests.