Allow it to return <Promise>
#970
Conversation
|
Can you rebase this? We should try it on www. |
| }; | ||
| } | ||
| // env.xit will not run anyways so we don't have to worry about it | ||
| env.it = makePromiseIt(env, 'it'); |
There was a problem hiding this comment.
let's make this so we it looks like this: env.it = promisifyIt(env.it, env);? Passing function names as strings is dangerous.
Also, can we do:
env.pit = env.it? We shouldn't break pit just yet – we can deprecate it and provide a codemod so people can switch and we'll remove it later in a major version. Here is what I recommend (in case this diff doesn't impact perf too much):
- Alias
ittopit. - Codemod everything on Facebook's www to
it. - Add a warning to
pit.
aaronabramov
force-pushed
the
pit
branch
2 times, most recently
from
eb0f961
to
1c96947
Compare
| @@ -0,0 +1,66 @@ | |||
| /** | |||
There was a problem hiding this comment.
left untouched for jasmine1
|
separated |
|
oh... i forgot i need to revert the runtime specs |
|
@cpojer ok. i reverted |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
to review:
jest-utils/jasmine-pitand__integration_tests_/promise_it/**It does not work with jasmine1 yet. If the direction is ok i'll add jasmine1 support to this PR.