-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new serializer plugin API in example #9847
Conversation
@@ -840,7 +840,7 @@ module.exports = { | |||
}; | |||
``` | |||
|
|||
`serialize` is a function that serializes a value using existing plugins. | |||
`printer` is a function that serializes a value using existing plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this printer
name come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link to https://github.com/facebook/jest/tree/master/packages/pretty-format (or https://www.npmjs.com/package/pretty-format) as well fo rmore detailed docs?
@SimenB good idea, I've added such link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
If you could update the versioned docs as well, that'd be lovely 🙏
Codecov Report
@@ Coverage Diff @@
## master #9847 +/- ##
==========================================
- Coverage 64.49% 64.47% -0.02%
==========================================
Files 289 289
Lines 12333 12333
Branches 3051 3051
==========================================
- Hits 7954 7952 -2
- Misses 3740 3741 +1
- Partials 639 640 +1
Continue to review full report at Codecov.
|
which versions should I update? only the current one? or do you want to go back with this change up to Jest 21? |
I don't think we have back to 21, but all we have would be great 👍 |
@SimenB I've applied those changes on all versioned docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
…pshots * runtime-require-resolve-outside: lint review improvements implement require.resolve option outsideJestVm for internal modules only basic jest-runtime require.resolve test Fix dead link to coverage CLI option (jestjs#9905) chore: remove dated node 6 reference from docs (jestjs#9895) Use the new serializer plugin API in example (jestjs#9847) chore: remove unused catch clauses (jestjs#9893)
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
According to
pretty-format
docs the new API has been introduced in Jest 21 but the main docs still mention only the old API (I wasn't actually able to find any reference to the new API).