Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack trace and runtime error reporting. #997

Closed
wants to merge 1 commit into from

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented May 12, 2016

The reporting code is a huge mess. This simplifies a bunch of things and makes everything go through the same code path and makes noStackTrace work again which hasn't worked properly for maybe half a year.

Fixes included:

  • When a single test is run and it throws a runtime error, we now show the "1 test suite failed" message.
  • Runtime errors, string errors and error objects thrown in tests now all render the same way and go through a single code path.
  • Stack trace printing can be disabled with --noStackTrace

yay, regex

Fixes #985.

@bypass-lint

@cpojer
Copy link
Member Author

cpojer commented May 12, 2016

@facebook-github-bot import

@ghost ghost added the CLA Signed ✔️ label May 12, 2016
@ghost
Copy link

ghost commented May 12, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@cpojer
Copy link
Member Author

cpojer commented May 12, 2016

@facebook-github-bot import

@ghost
Copy link

ghost commented May 12, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding --noStackTrace
1 participant