Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup getConsoleOutput arguments #9970

Closed
wants to merge 1 commit into from

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented May 4, 2020

Summary

Addressing TODO, remove root from getConsoleOutput, require full config.

Test plan

CI

@codecov-io
Copy link

Codecov Report

Merging #9970 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9970   +/-   ##
=======================================
  Coverage   63.90%   63.90%           
=======================================
  Files         293      293           
  Lines       12489    12488    -1     
  Branches     3082     3081    -1     
=======================================
  Hits         7981     7981           
+ Misses       3863     3862    -1     
  Partials      645      645           
Impacted Files Coverage Δ
packages/jest-console/src/getConsoleOutput.ts 0.00% <ø> (ø)
packages/jest-reporters/src/default_reporter.ts 82.60% <ø> (ø)
packages/jest-runner/src/runTest.ts 2.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d30a586...c0b9b49. Read the comment docs.

@thymikee thymikee added this to the Jest 26.x milestone May 5, 2020
@SimenB SimenB modified the milestones: Jest 26.x, Jest 27 May 6, 2020
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing changelog, otherwise LGTM 😀

@SimenB
Copy link
Member

SimenB commented Dec 5, 2020

Done in #10126

@SimenB SimenB closed this Dec 5, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants