Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync AwaitTaskCorrect with canonical version #92

Merged
merged 3 commits into from
May 31, 2022
Merged

Conversation

bartelink
Copy link
Collaborator

While we await fsharp/fslang-suggestions#840, this PR canonicalizes the implementation here to align with the Equinox and fsssnip edition in order to avoid people having to eliminate variation in the implementation from their inquiries when investigating threading issues.

@bartelink
Copy link
Collaborator Author

In this specific instance (which also applied to Propulsion, which cloned this impl), there are some minor variations that I've had @eiriktsarpalis confirm are not useful additions:

  • removal of redundant message text
  • removal of guard for theoretical unknown state
  • mapping cancellation to an exception (i.e., calling ec vs cc when task.IsCancelled)

@bartelink bartelink merged commit 701cc2e into master May 31, 2022
@bartelink bartelink deleted the atc-correct branch May 31, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant