Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destroy with no bundling #193

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

onhate
Copy link
Contributor

@onhate onhate commented Jan 4, 2024

Fixes #175

it works :)
image

const bundlingRequired = Stack.of(this).bundlingRequired;
const skipBuild = this.props.skipBuild;

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of an inline comment, do you mind adding this helpful table to docs/code-deployment-flow.md in a new section maybe titled "Conditional Build Logic"? Then maybe adding a brief explainer to accompany the table in the docs? Then you can just add a link to those docs in an inline comment. Future devs (including you, haha) will thank you :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@bestickley
Copy link
Collaborator

@onhate, from build logs:

::error::Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch.

Try running yarn build, then pushing changes. That should fix issue.

For forks, projen CI template requires you to run yarn build for any doc changes (and function/class signature changes).

@bestickley bestickley merged commit bc9694b into jetbridge:main Jan 4, 2024
4 checks passed
@bestickley bestickley deleted the fix-destroy-bundling branch January 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cdk destroy fails when open-next build is not present
2 participants