[nix profile] Changes to support format changes from nix 2.20 #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
savil
force-pushed
the
savil/profile-list-for-nix-2-20
branch
from
3d8613f
to
7674d3d
Compare
savil
force-pushed
the
savil/profile-list-for-nix-2-20
branch
2 times, most recently
from
6eea75d
to
bad3e85
Compare
savil
force-pushed
the
savil/profile-list-for-nix-2-20
branch
from
bad3e85
to
c5092c5
Compare
savil
commented
Feb 1, 2024
| index: 2, | ||
| unlockedReference: "github:NixOS/nixpkgs/52e3e80afff4b16ccb7c52e9f0f5220552f03d04#legacyPackages.x86_64-darwin.python39Packages.numpy", | ||
| lockedReference: "github:NixOS/nixpkgs/52e3e80afff4b16ccb7c52e9f0f5220552f03d04#legacyPackages.x86_64-darwin.python39Packages.numpy", | ||
| nixStorePaths: []string{"/nix/store/qly36iy1p4q1h5p4rcbvsn3ll0zsd9pd-python3.9-numpy-1.23.3"}, |
There was a problem hiding this comment.
should add a test-case with name: field
There was a problem hiding this comment.
actually, this test is for legacy nix profile list parsing. Not the modern --json output. Renamed to clarify.
gcurtis
approved these changes
Feb 1, 2024
github-merge-queue bot
pushed a commit
to jetify-com/devbox-install-action
that referenced
this pull request
Mar 4, 2024
upgrade devbox cli test to use version 0.9.1, which addresses a nix output change in version 2.20. Corresponding Devbox PR jetify-com/devbox#1770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The latest nix version (2.20) changed how the nix profile output is represented:
From the release notes:
and for
nix search:TODOs:
nix.readManifestto handle the new formatnix searchrequires a regex to be passedFixes #1767
How was it tested?
CICD should pass
Installed nix 2.20.1 locally and am using Devbox with it to add, remove packages and run scripts and shell.
verified flake updating works:
examples/flakes/remote. Diddevbox shell, dropped thev0.43.1from process-compose flake, diddevbox update, and verified thatprocess-composenow had the latest version (IIRC0.80+)examples/flakes/php. Diddevbox shell, edited the flake to dropdsand diddevbox update. Verified nodsinphp -m | grep ds