Use custom informer-gen that supports filters

[munnerz]

This PR switches us to use munnerz/code-generator temporarily, which includes the changes in kubernetes/kubernetes#54660. I've then updated our codegen scripts to also generate informers for internal kubernetes types (although not a client or lister, as we can re-use client-go for this).

I'm hoping my PR will be merged soon, at which point we can remove the alternate repo source, but for now this lets us clear up the mess that is our SharedInformerFactory.

NONE

[wallrj]

@munnerz The plan makes sense.

A quick thougt. Could we instead maintain a Jetstack fork of the code-generator and point dep at that.
That's how I've seen this done in Python world.
Or is that going to be a massive pain with GOPATH?

[munnerz]

Yeah that is what I hoped to do originally. dep isn't able to handle that, and actually their justifications are fair (if two packages both depend on the same package, but one of them specifies a different 'source', what should happen, as we can't check out code from two places so the dependency cannot be met).

It'd be nice if there were some way to do it, but doesn't seem like it.

I've actually just run into a new problem, which is that dep wipes out the vendor/ dir upon dep ensure, so I've had to actually update the Makefile to include a ln -s which is not the best. I'm really hoping my PR gets accepted upstream so we don't have to do this forever! There's been some good/positive discussion on it, so I fingers crossed 😄

[wallrj]

Hey @munnerz

I just read: https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md#constraint

[[constraint]]
...
  # Optional: an alternate location (URL or import path) for the project's source.
  source = "https://github.com/myfork/package.git"

Found via the response to this comment: golang/dep#248 (comment)

[munnerz]

Thanks @wallrj! Missed that!!

[munnerz]

@wallrj this is now passing! 🎉

I've also opened a follow up PR #82 that switches the ElasticsearchController to use these new factories.

[wallrj]

Thanks @munnerz

Looks great! I looked at #82 and the new factory code looks much neater.

I think we can delete the third_party stuff now.

Otherwise

/lgtm

[wallrj]

❓ I was going to ask if this is the correct branch in your forked repo, but it looks like you've applied the changes there too: https://github.com/munnerz/code-generator/tree/release-1.8

[munnerz]

Yep - otherwise there were more changes to generated files that were unrelated. Thought it best to make this 1:1

[wallrj]

❓ Are we still using the third_party sub-directory

[munnerz]

Yep, but not with any vendor hacks this time (symlinks).

This is just a place to store the generated filter-able informers from the main k8s codebase.

[munnerz]

/approve

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, wallrj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [munnerz]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[jetstack-bot]

Automatic merge from submit-queue.