Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix progress format when ruby core lib mathn is loaded #31

Closed
wants to merge 2 commits into from

Conversation

larskluge
Copy link
Contributor

Very small fix to make the progress format work also when 'mathn' is required somewhere else in your code.

Not sure if it's ok to modify the spec_helper to require mathn. But needs to be loaded somewhere to show that the test suite is failing.

@larskluge
Copy link
Contributor Author

oh, nice side effects with other ruby versions.. however, let me know what you think and i can improve the pull request.

@jfelchner
Copy link
Owner

@aekym Any word on this? I'm going to try to get a new release out in the next couple days.

@larskluge
Copy link
Contributor Author

Sry for the delay. Will try to dig into it by today. Keep you posted.

On Mon, Dec 17, 2012 at 1:45 AM, Jeff Felchner [email protected]:

@aekym https://github.com/aekym Any word on this? I'm going to try to
get a new release out in the next couple days.


Reply to this email directly or view it on GitHubhttps://github.com//pull/31#issuecomment-11431963.

@larskluge
Copy link
Contributor Author

SimpleCov.start + mathn results in segmentation fault for Ruby MRI 1.9.3 and in very weird errors in jRuby 1.7.0 (MIR 1.9.3 equivalent). Not sure how to come up with a better solution.

@jfelchner jfelchner closed this in 5af929b May 26, 2013
@jfelchner
Copy link
Owner

@aekym awesome job. I FINALLY got this merged in. It's in the v1.1.0 release.

Thanks again!

@larskluge
Copy link
Contributor Author

Ha, that's awesome--thanks!

On Sun, May 26, 2013 at 2:42 AM, Jeff Felchner [email protected]
wrote:

@aekym awesome job. I FINALLY got this merged in. It's in the v1.1.0 release.

Thanks again!

Reply to this email directly or view it on GitHub:
#31 (comment)

jfelchner added a commit that referenced this pull request May 12, 2016
Closes #31

* aekym-master:
  Upgrade simplecov so it is resilient to mathn being loaded
  fix progress format when core lib mathn is loaded
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the outdated Inactive - Outdated label Dec 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Problem - Bug outdated Inactive - Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants