Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit SCA recursive scan #555

Merged
merged 11 commits into from
Nov 5, 2023
Merged

Audit SCA recursive scan #555

merged 11 commits into from
Nov 5, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 24, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

depends on and description about the feature: jfrog/jfrog-cli-core#994

@attiasas attiasas added the improvement Automatically generated release notes label Oct 24, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 24, 2023
@attiasas attiasas requested a review from yahavi October 26, 2023 06:05
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Oct 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 26, 2023
@attiasas attiasas marked this pull request as ready for review October 26, 2023 09:29
@attiasas attiasas requested a review from eyalbe4 November 1, 2023 08:56
@eyalbe4 eyalbe4 added new feature Automatically generated release notes and removed improvement Automatically generated release notes labels Nov 1, 2023
eyalbe4
eyalbe4 requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also make the necessary changes to https://github.com/jfrog/documentation.

docs/templates/.frogbot/frogbot-config.yml Outdated Show resolved Hide resolved
docs/templates/.frogbot/frogbot-config.yml Outdated Show resolved Hide resolved
docs/templates/.frogbot/frogbot-config.yml Outdated Show resolved Hide resolved
docs/templates/github-actions/frogbot-scan-pull-request.yml Outdated Show resolved Hide resolved
utils/params.go Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023

@attiasas attiasas merged commit 8a93303 into jfrog:dev Nov 5, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @eyalbe4