Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace poetry update with poetry lock --no-update #1235

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

BartSchuurmans
Copy link

@BartSchuurmans BartSchuurmans commented Aug 14, 2024

poetry update is a command that upgrades all dependecies to their latest compatible version. This is not desired when you just want to configure a repository. Instead, poetry lock --no-update should be run after configuring the repository to update the lock file.

This fixes the behavior of Frogbot upgrading all dependencies when called in CI.

Fixes #835

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Copy link
Contributor

github-actions bot commented Aug 14, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@BartSchuurmans
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@BartSchuurmans
Copy link
Author

recheck

@BartSchuurmans BartSchuurmans marked this pull request as ready for review August 14, 2024 19:20
`poetry update` is a command that upgrades all dependecies to their
latest compatible version. Instead, `poetry lock --no-update` should be
run after configuring the repository to update the lock file.

This fixes the behavior of Frogbot upgrading all dependencies when
called in CI.
@BartSchuurmans BartSchuurmans changed the title Replace poetry update with poetry install Replace poetry update with poetry lock --no-update Aug 14, 2024
@BartSchuurmans
Copy link
Author

Could someone take a look at this? My company is a paying customer of JFrog but has difficulties using it because we widely use poetry and the current behaviour is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant