Exclude JAS Scan Flag #836
Conversation
| @@ -48,6 +48,9 @@ func getIacScanResults(serverDetails *config.ServerDetails, analyzerManager util | |||
| err = errors.Join(err, cleanupFunc()) | |||
| } | |||
| }() | |||
| if utils.ExcludeScan(scannersToExclude, iacScanCommand) { | |||
| return nil, false, nil | |||
There was a problem hiding this comment.
Let's add a debug level log that the IaC scan is skipped
| analyzerManagerExecuter utils.AnalyzerManagerInterface = &utils.AnalyzerManager{} | ||
| skippedDirs = []string{"**/*test*/**", "**/*venv*/**", "**/*node_modules*/**", "**/*target*/**"} | ||
| scannersToExclude = []string{} |
There was a problem hiding this comment.
This comment is not related to this PR, but is more general -
Please prefer not to use global variables. Instead, the recommended way is to use a new JasManager struct.
One design pattern is to pass a pointer of the struct when needed to each one of the scanners.
Another design pattern is to use inheritance/decoration, whereby every scanner contains the JasManager struct.
| @@ -39,6 +41,7 @@ func GetExtendedScanResults(xrayResults []services.ScanResponse, dependencyTrees | |||
| if err = utils.CreateAnalyzerManagerLogDir(); err != nil { | |||
| return nil, err | |||
| } | |||
| scannersToExclude = strings.Split(excludeScan, ";") | |||
There was a problem hiding this comment.
Let's also trim strings to allow for example: --exclude-scan=contextual_analysis; secrets
| @@ -49,6 +50,9 @@ func getSecretsScanResults(serverDetails *config.ServerDetails, analyzerManager | |||
| err = errors.Join(err, cleanupFunc()) | |||
| } | |||
| }() | |||
| if utils.ExcludeScan(scannersToExclude, secretsFeatureName) { | |||
| return nil, false, nil | |||
There was a problem hiding this comment.
Let's add a debug level log that the secret scan is skipped
| for _, s := range scansToBeExcluded { | ||
| if s == scan { | ||
| return true | ||
| } | ||
| } | ||
| return false |
There was a problem hiding this comment.
Can be inlined:
| for _, s := range scansToBeExcluded { | |
| if s == scan { | |
| return true | |
| } | |
| } | |
| return false | |
| return slices.Contains(scansToBeExcluded, scan) |
This PR contains the following:
-exclude-scan=contextual_analysis;secrets