-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate xray url #160
Open
hadarshjfrog
wants to merge
2
commits into
jfrog:dev
Choose a base branch
from
hadarshjfrog:validate-xray-url
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Validate xray url #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadarshjfrog
force-pushed
the
validate-xray-url
branch
from
August 30, 2024 11:41
9878122
to
611df08
Compare
hadarshjfrog
force-pushed
the
validate-xray-url
branch
from
August 30, 2024 11:48
611df08
to
ff7aafa
Compare
hadarshjfrog
added
bug
Something isn't working
safe to test
Approve running integration tests on a pull request
labels
Aug 30, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 30, 2024
hadarshjfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Aug 30, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Aug 30, 2024
hadarshjfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 3, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 3, 2024
hadarshjfrog
force-pushed
the
validate-xray-url
branch
from
September 5, 2024 07:46
ff7aafa
to
e60da42
Compare
hadarshjfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 8, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 8, 2024
hadarshjfrog
requested a deployment
to
frogbot
September 16, 2024 21:39
— with
GitHub Actions
Waiting
hadarshjfrog
temporarily deployed
to
frogbot
September 16, 2024 21:42
— with
GitHub Actions
Inactive
hadarshjfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 16, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 16, 2024
hadarshjfrog
force-pushed
the
validate-xray-url
branch
from
September 17, 2024 06:42
3168835
to
d356b6e
Compare
hadarshjfrog
requested a deployment
to
frogbot
September 17, 2024 06:42
— with
GitHub Actions
Waiting
hadarshjfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
@hadarshjfrog I think it's worth adding a test to audit_test.go - configure a server with Xray URL only and validate we get JAS results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.When configuring
xray-url
only, without theurl
- the audit command didn't recognize them, and couldn't set JAS scanners: