Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable generating SARIF for GitHub advance security tab if not entitled for JAS #166

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Disable generating SARIF for GitHub advance security tab if not entitled for JAS #166

merged 2 commits into from
Sep 5, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Sep 5, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

disable generating SARIF for GitHub advance security tab if not entitled for JAS

@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 5, 2024
@attiasas attiasas changed the title If no JAS no GHAS Disable generating SARIF for GitHub advance security tab if not entitled for JAS Sep 5, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Sep 5, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas merged commit 40f53cc into jfrog:dev Sep 5, 2024
9 checks passed
@attiasas attiasas deleted the if_no_JAS_no_GHAS branch September 5, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadarshjfrog hadarshjfrog hadarshjfrog approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @hadarshjfrog