Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fingerprint field to simple json format #169

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Add fingerprint field to simple json format #169

merged 3 commits into from
Sep 10, 2024

Conversation

orz25
Copy link
Contributor

@orz25 orz25 commented Sep 9, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@orz25 orz25 requested a review from attiasas September 9, 2024 11:38
@attiasas attiasas changed the title Add sast fingerprint field to simple json format Add fingerprint field to simple json format Sep 9, 2024
@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@attiasas attiasas mentioned this pull request Sep 9, 2024
Merged
4 tasks
attiasas
attiasas requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, checkout my comments

formats/simplejsonapi.go Outdated Show resolved Hide resolved
utils/resultstable.go Show resolved Hide resolved
@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
hadarshjfrog
hadarshjfrog reviewed Sep 9, 2024
View reviewed changes
formats/sarifutils/sarifutils_test.go
@@ -615,3 +616,30 @@ func TestGetInvocationWorkingDirectory(t *testing.T) {
assert.Equal(t, test.expectedOutput, GetInvocationWorkingDirectory(test.invocation))
}
}

func TestGetResultFingerprint(t *testing.T) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can we add a test of same finding, in same file - and have two different fingerprints?
(here or https://github.com/jfrog/frogbot/pull/748/files)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it to frogbot integration tests

@orz25 orz25 added the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 10, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas self-requested a review September 10, 2024 10:11
@orz25 orz25 merged commit d1ed2c2 into jfrog:dev Sep 10, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadarshjfrog hadarshjfrog hadarshjfrog left review comments

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orz25 @attiasas @hadarshjfrog